search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

[spec] Factorize default facts #178

Closed sbadia closed 10 years ago

sbadia commented 10 years ago

Just a simple clean of duplicated facts across specs

blkperl commented 10 years ago

+1

igalic commented 10 years ago

shouldn't we maybe use https://github.com/apenney/puppet_facts here?

sbadia commented 10 years ago

@igalic oh! nice indeed, puppet_facts is only used on puppetlabs/puppetlabs-mysql module ?

igalic commented 10 years ago

it's the first consumer so far.

sbadia commented 10 years ago

ok, i'll take a look for puppet-gitlab :-)

igalic commented 10 years ago

my only problem with puppet-facts is that so far it has — almost exclusively — pe facts. which makes it quite useless for a community, who mostly uses the foss version