search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

Add flexibility to system packages that are controller by the Gitlab mod... #182

Closed Spredzy closed 10 years ago

Spredzy commented 10 years ago

...ule

Currently, the list of $system_packages in Gitlab module, might interfer with the setup one has already in place (ie. Duplicate declaration error).

In order to still provide a functionally working installation by default, but yet avoid Duplicate declaration error on specific this commits allows one to specify which $system_packages should be controlled by the Gitlab module.

So if one has the puppetlabs/gcc module enabled on the system, one could specify the following $system_packages parameter :

$system_packages = ['libicu-devel', 'perl-Time-HiRes','libxml2-devel',
                    'libxslt-devel','python-devel','libcurl-devel',
                    'readline-devel','openssl-devel','zlib-devel',
                    'libyaml-devel','patch']

Note how gcc-c++ is not specified.

PS. I know that this module is using ensure_packages(), to check if a package is present, but another module might not, hence resulting in the error mentioned

sbadia commented 10 years ago

Oh! Nice approach :-) :+1: for this change. Thanks Spredzy! Another review ?

igalic commented 10 years ago

+1, will need a rebase though

sbadia commented 10 years ago

@Spredzy could you rebase your change ?

Spredzy commented 10 years ago

@sbadia @igalic done !

sbadia commented 10 years ago

thanks!