search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

Updating the environment used by the update hook to rbenv ruby #186

Closed frconil closed 10 years ago

frconil commented 10 years ago

It appears that the "update" hook from gitlab-shell defaults to system ruby, raising errors on mismatched versions for rake when trying to edit files using the web interface. Forcing it to use rbenv ruby solves the issue.

Fixes https://github.com/sbadia/puppet-gitlab/issues/185

igalic commented 10 years ago

+1 looks good to me. (but i haven't tested it yet)

igalic commented 10 years ago

@sbadia @blkperl @atomaka ping

frconil commented 10 years ago

Update that with gitlab 7.3 comes a dependency on gitlab-shell > 2.0.0

As a result the update hook is replaced by a pre-receive and post-receive hook.

igalic commented 10 years ago

good, good. as soon as @alup updates rbenv, we should merge/release this (and #189)

sbadia commented 10 years ago

Sorry for the delay… It seem's ok for me =) (just tested with beaker + manuals steps) $ curl http://pub.sebian.fr/pub/frconil-186-gitlab.log We can merge this PR @frconil @igalic many thanks!