search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

check for existence of update hook #199

Closed setola closed 9 years ago

setola commented 10 years ago

It seems that in the latest version of gitlab-shell they have removed the update hook: https://gitlab.com/gitlab-org/gitlab-shell/commit/7eb45672b77a0337e6568ef64cd84e13027f2d7b

I'm using

I've adopted this solution because it seems to me the most compatible with different versions of gitlab and gitlab-shell.

Comments are welcome :+1:

igalic commented 10 years ago

any reference as to why they'd do that?

setola commented 10 years ago

From their changelog: https://gitlab.com/gitlab-org/gitlab-shell/blob/master/CHANGELOG#L11 Replace update hook with pre-receive and post-receive hooks.

but I've realized that yesterday they committed this (authored 8 days ago): https://gitlab.com/gitlab-org/gitlab-shell/commit/3ef7cdf9f94035da5640a585b8c49b0693af2090 and the hook is back in the master but there's still no tag https://gitlab.com/gitlab-org/gitlab-shell/blob/master/hooks/update

Also this PR is currently on development\discussion: https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/1

I can't say what they will come out with: maybe they will restore the update hook, but for sure on version v2.1.0 such hook is missing...

igalic commented 10 years ago

ack. so maybe we should steer clear of 2.1.0?

setola commented 10 years ago

if 2.1.1 or 2.2.0 have this hook when they come out, I will agree :)

sbadia commented 9 years ago

update gitlab-shell template is not shipped anymore by this module, sorry for the delay, and thanks anyway!