search

sbadia / puppet-gitlab

Puppet module for manage GitLab installation
http://forge.puppetlabs.com/sbadia/gitlab
GNU General Public License v3.0
131 stars 76 forks source link

Expose Additional Config Options #238

Open wazoo opened 9 years ago

wazoo commented 9 years ago

I was looking for the option to change the default theme and I discovered there were quite a few options that weren't exposed so I went and found as many as I could and exposed them with additional options.

As with my other pull requests, the same tests fail when I do a rake spec on master vs this branch so I am not sure whats up with that. I didn't see tests for every single option (seemed there were a few but not total coverage) so I didn't add any for the ones I added, I can do that if need be.

wazoo commented 9 years ago

Whoops I forgot to add the options to init.pp, ignore this until that is done.

wazoo commented 9 years ago

Okay, all documented, initialized and validated, should be good to go!

I have no idea why those builds are failing, when running it locally I get:

Puppet::PreformattedError: Evaluation Error: Unknown function: 'validate_numeric'. at /[...]/spec/fixtures/modules/gitlab/manifests/init.pp:633:3 on node [hostname]

That is absolutely a function, it is part of puppetlabs/stdlib (in the version in this packages metadata): validate_integer

It looks like it was added not that long ago so maybe there is a testing gem out of date.