search

sbaeumlisberger / VirtualizingWrapPanel

Implementation of a comprehensive VirtualisingWrapPanel for WPF
MIT License
242 stars 33 forks source link

Problems dragging the vertical scrollbar with grouping #30

Closed dlangell closed 2 years ago

dlangell commented 2 years ago

I know grouping is still considered experimental, but I've seen several issues while dragging the vertical scrollbar up and down while grouping is being used.

First is that if Recycling is used while grouping, the sample application will crash while dragging the scrollbar. My own application does not crash, but I have noticed a steady increase in memory usage while dragging the scrollbar. If Standard mode is used instead of Recycling, I don't see either of these issues.

Second is if I set the Spacing Mode to None while grouping and slowly decrease the width of my application window just to the point where the last column wraps and leaves a large amount of empty space to the right of the list (that's almost big enough for another column) and then start dragging the vertical scrollbar up and down, my application will eventually freeze. Unfortunately, I haven't been able to reproduce this in the sample application. But it doesn't seem to happen in my application if I'm not grouping items or if the list width is not just a few pixels shy of allowing an extra column. I'm not sure what's going on there. But it does seem somewhat similar to Issue #2 : Infinite loop issue (https://github.com/sbaeumlisberger/VirtualizingWrapPanel/issues/2) in that if I set ScrollViewer.VerticalScrollBarVisibility="Visible" the issue seems to be fixed. I'm okay with this workaround for now (actually seems to maybe increase performance), but still wanted to point it out.

Version Info Package Version: 1.5.7 .NET Version: 4.8 Installed, 4.5.2 targeted OS Version: Windows 10 Pro 20H2 Build 19042.1348

sbaeumlisberger commented 2 years ago

Thanks for the detailed description. It's right grouping is still experimental, but I'll have a look as soon as I have some time.

sbaeumlisberger commented 2 years ago

The sample application has used an old version. I fixed that.

Unfortunately, I was not able to reproduce your second problem. If you could provide a small sample application, I could investigate the problem further. Otherwise, there's not much I can do.

dlangell commented 2 years ago

Thank you for updating the sample application.

I tried to trim my application down to the barebones so I could give you a sample. But in doing so, the problem went away. I must have something else going on. If I have time in the future, I'll try to track it down. I'll also test with any new versions you release that might be less experimental for grouping. For the time being, I'm content to leave the VerticalScrollBarVisibility set to Visible since this also seems to fix the issue.

sbaeumlisberger commented 2 years ago

Alright, I'm glad that you have a workaround.

sbaeumlisberger commented 2 years ago

I will close this issue due to inactivity. Feel free to open a new one if you have more information on how to reproduce the issue.