sbailey / surveyqa

DESI Survey QA Dashboard
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

tiles vs. time progress normalization #10

Closed sbailey closed 5 years ago

sbailey commented 5 years ago

Something is wrong in the normalization and trend lines for the tiles vs. time plot:

image

In this case, there should be 3 trend lines, one for each of DARK, GRAY, and BRIGHT with different numbers of total tiles after 5 years for each program:

In [5]: for p in set(t['PROGRAM']):
   ...:     print(p, np.count_nonzero(t['PROGRAM'] == p))
   ...:     
BRIGHT 6028
GRAY 2005
DARK 8038

It also looks like the plot is showing the number of exposures for each program instead of the number of tiles:

In [8]: for p in set(exp['PROGRAM']):
   ...:     ii = exp['PROGRAM'] == p
   ...:     nexp = np.count_nonzero(ii)
   ...:     ntiles = len(set(exp['TILEID'][ii]))
   ...:     print(p, nexp, ntiles)
   ...:     
CALIB 810 1
GRAY 850 296
BRIGHT 1703 785
DARK 4093 1595

e.g. the DARK line should have reached 1595, not 4093.

williyamshoe commented 5 years ago

I see the problem; I did make a new table without repeated tiles, but continued using the full exposures table when making the plot. I have fixed it now in the new branch, and added separate "ideal lines" for DARK, GRAY, and BRIGHT.