search

sbailey / surveyqa

DESI Survey QA Dashboard
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Make summary page faster #56

Closed sbailey closed 5 years ago

sbailey commented 5 years ago

This PR makes surveyqa.summary.make_plots ~2.7x faster from a variety of optimizations. I'll add comments inline to explain the changes.

@ana-lyons @rdoshi99 @williyamshoe please take a look at these changes to understand what changed and why. Visually they appear to produce identical output, though the summary.html files are not identical with master, though I haven't determined exactly what is different and why (maybe just rounding / timestamps? maybe worse? please double check me...)

On Monday we can discuss the tools I used to identify the hotspots for optimization.

sbailey commented 5 years ago

@ana-lyons @williyamshoe @rdoshi99 have any of you run this branch? Any problems, comments, or objections? I'd like to get this merged into master to avoid future merge conflicts as other work happens.

rdoshi99 commented 5 years ago

No issues on my end

williyamshoe commented 5 years ago

Same; no errors/warnings come up, and summary seems significantly faster.

sbailey commented 5 years ago

Thanks for the checks; merging now.