Closed rdoshi99 closed 5 years ago
I committed changes on this branch, but they are not showing up in the commit history. Trying to figure that out before I reopen the PR
This is the image of the model with rough approximates through hand calculations:
The other comment I have is that I added the label for moon fraction but I could not get it to align right on the plot:
This is because the Label annotation on bokeh doesn't support the same type of align as Title does I tried adding a second Title and this was the result: Where the actual plot title gets pushed up farther above, which I thought would mess with the styling already done
Created a sine function to approximate the phase of the moon through the getPhase function
helper functions include: phaseSign which determines if the moon phase is waxing waning toDatetime which converts a night into a datetime object (perhaps this function should be merged) numNightsFullZero (which calculates the number of days which have passed since a specific full moon on Nov. 11, 2019) getWedge which, given the phase of the moon, plots a point onto the figure (from skypath plot) as either a ring, wedge, or full circle depending on the phase of the moon
This also adds a label to the top of the skypath plot with the fraction of the moon illuminated
This addresses issue #27