search

sbakiu / immoscout-bot

FastAPI application to crawl sites and send telegram push notification deployed on Heroku
Apache License 2.0
8 stars 4 forks source link

SECRET env var #9

Closed edivadiranatnom closed 1 year ago

edivadiranatnom commented 1 year ago

Hey thanks for this bot, it's amazing! I have a question tho. In the last steps there's no clarification of what secret should be set for heroku config:set -a $APP_NAME SECRET=<SECRET>. Could you please explain what secret is expected there? 🙏

sbakiu commented 1 year ago

Secret is used here: https://github.com/sbakiu/immoscout-bot/blob/main/app/main.py#L21 Since the endpoint (in my case) was publicly accessible, SECRET was used to make sure the requests are coming from a trusted source. It is expected to be a string.

Please note the project is not maintained and things might have changed.

edivadiranatnom commented 1 year ago

@sbakiu i see. Thanks for the clarification and publishing the project, I'm using it as a starting point because as you guessed it needs some adjustments :D