search

sbarex / SourceCodeSyntaxHighlight

Quick Look extension for highlight source code files on macOS 10.15 and later.
GNU General Public License v3.0
3.02k stars 72 forks source link

Wrong colors with RTF engine #126

Open setanarut opened 3 years ago

setanarut commented 3 years ago

Wrong colors with RTF engine, Colors look more pastel (brighter) in RTF mode.

RTF Engine

Ekran Resmi 2021-11-24 15 57 40

HTML Engine (Looks normal)

Ekran Resmi 2021-11-24 15 58 15
sbarex commented 3 years ago

It is probably due to a different management / conversion of the color space during the display phase. The color value is exported correctly in both rtf and html output file. In the visualization phase then something happens that I cannot control.

The background color difference in rtf mode between the preview in the application and in the quicklook view is due to a different management of the code. However, it is not possible to use the application code for the quicklook preview on Monterey (and in any case this difference only affects the background color).

setanarut commented 3 years ago

The problem can be overcome by making the background color darker. If it is impossible to fix, it should be added to the documentation as "known bugs".

sbarex commented 3 years ago

The problem in not only in the background but in all colors. The right appearance is with the html engine.

I could not understand what conversion is done in the rtf display.

I will add a note in the known bugs.

ph0ngp commented 2 years ago

I am using Monterey 12.2.1 . In dark mode, the background of RTF engine isn't even dark anymore. It shows full white. The color of the code is still from the dark theme, but the background becomes white.

Here is RTF (dark color scheme syntax, white background) Screen Shot 2022-02-15 at 1 37 04 PM

Here is HTML engine (normal) Screen Shot 2022-02-15 at 1 37 20 PM

sbarex commented 2 years ago

Sorry, must be fixed on release 2.1.8 (56).