search

sbdchd / celery-types

:seedling: Type stubs for Celery and its related packages
Apache License 2.0
76 stars 38 forks source link

Why not typeshed? #14

Open hydrargyrum opened 3 years ago

hydrargyrum commented 3 years ago

The typeshed repository is certainly the right place where to put those types. Why not submitting the project to them?

sbdchd commented 3 years ago

Basically these stubs were started before typeshed releases were disconnected from type checker releases, so by having the types in their own package, it is/was easier to get updates through

hydrargyrum commented 3 years ago

Ok, if this problem is fixed, would you consider submitting it to typeshed? That would also bring much more visibility to your project.

sbdchd commented 3 years ago

Currently these types are pretty incomplete so they would need to be fleshed out more before submission

jeking3 commented 2 years ago

It looks like this can be closed? The author is very responsive to bug reports, and I fear within typeshed it may not be as awesome.

hydrargyrum commented 2 years ago

IMHO, I can't see why the project wouldn't be followed if it's in typeshed. Being in typeshed only means it's available to a wider audience and is better integrated in checkers like mypy.

huyz commented 2 years ago

Isn't typeshed deprecated? http://mypy-lang.blogspot.com/2021/05/the-upcoming-switch-to-modular-typeshed.html

hydrargyrum commented 2 years ago

I can't see how it is deprecated. stub_uploader uploads stuff from typeshed repository to separate pypi packages. Your page only mentions reading pypi, which is not incompatible with using the typeshed repository.

huyz commented 2 years ago

Typeshed links to PEP561 which says:

New third party stub libraries SHOULD distribute stubs via the third party packaging methods proposed in this PEP in place of being added to typeshed. Typeshed will remain in use, but if maintainers are found, third party stubs in typeshed MAY be split into their own package.