search

sbdchd / django-types

:doughnut: Type stubs for Django
MIT License
188 stars 62 forks source link

Missing fallback_keys parameter for Signer.__init__ (Django 4.1) #141

Open nuschk opened 1 year ago

nuschk commented 1 year ago

The fallback_keys parameter to Signer.__init__ is missing. The complete signature should read as follows:

class Signer:
    def __init__(
        self,
        key: Optional[Union[bytes, str]] = ...,
        sep: str = ...,
        salt: Optional[str] = ...,
        algorithm: str = ...,
        fallback_keys: Optional[List[str]] = ...,
    ) -> None: ...

This is new in Django 4.1, which is, I hope, in scope?

Thanks!

sbdchd commented 1 year ago

Thank you for the report!

yeah this project aims to track the latest version of django, but tends to get out of sync

nuschk commented 1 year ago

Understandable, that's I guess the nature of these kinds of things. Would it help for me to do a PR?