sbdchd / django-types

:doughnut: Type stubs for Django
MIT License
188 stars 62 forks source link

Add missing admin filter and fix model indexes #149

Closed duilio closed 1 year ago

duilio commented 1 year ago

Hello,

this PR actually makes two changes:

I am not sure if this is the right way to contribute to this repository.

duilio commented 1 year ago

I guess CI is not working due to this: https://circleci.com/blog/january-4-2023-security-alert/

sbdchd commented 1 year ago

ugh circle CI is broken

in terms of tests there are some in https://github.com/sbdchd/django-types/blob/72b6ec53b507ebf2a5290829c11c934d432104ec/tests/trout/models.py#L356-L364 where we essentially write some functions that expect a given type and type error if they get something else

duilio commented 1 year ago

@sbdchd in the meantime I've added some tests. I had to push some other changes due to black formatting.

sbdchd commented 1 year ago

Okay I did what circleci said to do, logout and in again so maybe that's fixed it

can you push another commit?

it can be empty I think

git commit -m "fix ci" --allow-empty
duilio commented 1 year ago

@sbdchd unfortunately it doesn't seem to work yet.. :-( same message about oauth.