sbdchd / django-types

:doughnut: Type stubs for Django
MIT License
187 stars 62 forks source link

EmailMessage.attach does not accept MIMEBase #174

Open Mapiarz opened 1 year ago

Mapiarz commented 1 year ago

Stubs seem to be handling this correctly: https://github.com/typeddjango/django-stubs/blob/a7982d4e2a60abfd65124461a4bf575c6657f5cf/django-stubs/core/mail/message.pyi#L103

This incorrect annotation likely extends to other types and fields/methods.

If one wanted to contribute, what's the smartest way to go about catching up with stubs?

sbdchd commented 1 year ago

There isn't really a standard way to catch up with the Django-stubs, essentially I add stuff as I need it for this package

Incremental changes is probably best overall