sbdchd / djangorestframework-types

:sunflower: Type stubs for Django Rest Framework
MIT License
37 stars 9 forks source link

GenericAPIView type stub lacks get_queryset method #17

Open sminnee opened 2 years ago

sminnee commented 2 years ago

I'm running djangorestframework 3.13.1 and djangorestframework-types 0.6.0

GenericAPIView defines a get_queryset(self) method.

The type stub does not.

It looks like djangorestframework-stubs package has added this - https://github.com/typeddjango/djangorestframework-stubs/blob/master/rest_framework-stubs/generics.pyi#L20 - is it worth pulling upstream changes into this package?

dolfandringa commented 1 year ago

This was resolved in version 0.7.1 by @knyghty (fancy seeing you here), but somehow a new 0.8.0 (see #31) seems to have been published since then that isn't in this repository that reverted that fix again

(screenshot from the downloaded version from pypi)

image