sbdchd / mongo-types

:fallen_leaf: Type stubs for mongoengine, pymongo, and bson
Apache License 2.0
19 stars 8 forks source link

fix: Fix CI; update deps #73

Closed last-partizan closed 11 months ago

last-partizan commented 11 months ago

I fixed some type errors after pyright update, but there's some Mismatch between signature of __new__ and __init__ left.

But, that's better that completely broken ci :)

last-partizan commented 11 months ago

And bson/pymongo already have typing, so i removed them from here.

sbdchd commented 11 months ago

Looks good, thank you for removing bson and pymongo, good to hear they have integrated type stubs!!

sbdchd commented 11 months ago

CI is a lil angry:

+ [[ -n true ]]
+ black --check .
would reformat /home/circleci/project/mongoengine-stubs/base.pyi
would reformat /home/circleci/project/typings/mongoengine/base.pyi

Oh no! 💥 💔 💥
2 files would be reformatted, 20 files would be left unchanged.

Exited with code exit status 1
last-partizan commented 11 months ago

All green, but that's a surprise, there should be 4 errors related to error: Mismatch between signature of __new__ and __init__

Don't merge this yet, i'll look into it.

last-partizan commented 11 months ago

Updated pyright, now it correctly reports those 4 errors.

last-partizan commented 11 months ago

Fixed it, now it's ready to merge @sbdchd ;)

sbdchd commented 11 months ago

Thank you!!