search

sbechet / xmrsplayer

Mirror of https://codeberg.org/sbechet/xmrsplayer
MIT License
7 stars 1 forks source link

"Note off" notes don't work #4

Closed vurpo closed 6 months ago

vurpo commented 6 months ago

When I add "note off" notes in my files, this library still keeps playing the previous notes like nothing happened. Currently I'm setting volume to 0 instead of using note off, as a workaround for this.

vurpo commented 6 months ago

testcase.xm.zip

Here's a simple test XM file, which should have a note turning on and off periodically, but using xmrsplayer it's constantly on instead.

sbechet commented 6 months ago

Tested with ft2 clone v1.65: you right :(

sbechet commented 6 months ago

Can you test last version?

I would be happy to know if you make free software with xmrsplayer :)

vurpo commented 6 months ago

I'll test later. I just released this demo: https://www.youtube.com/watch?v=V7GjQy8hxq4 / https://github.com/vurpo/laser-demo which uses xmrsplayer.

Although I ran into a bug here: on the demoparty's compo machine, the xmrsplayer ran way too fast (sample rate was correct, but it advanced through rows way too quickly). Didn't manage to investigate what the issue was, and it worked correctly on a different Windows and macOS machine I tried.