search

sbechet / xmrsplayer

Mirror of https://codeberg.org/sbechet/xmrsplayer
MIT License
7 stars 1 forks source link

Vibrato sounds different! #6

Closed ofetch closed 3 months ago

ofetch commented 3 months ago

Hello and thank you for making this nice XM player.

When I use xmrsplayer to play this work called Final Showdown the vibrato parts sound different than other players like XMPlay or the online player on the website it's hosted in.

I hope this library can match the correctness of other players mentioned.

Thank you.

sbechet commented 3 months ago

Hello and thank you for making this nice XM player.

Thank you, it's my way of rebelling against the excessive professionalization of IT.

When I use xmrsplayer to play this work called Final Showdown the vibrato parts sound different than other players like XMPlay or the online player on the website it's hosted in.

I hope this library can match the correctness of other players mentioned.

I am going to watch. I'm gradually removing the historical tables but real mathematical functions for the effects, maybe that's why. I'll find out if it comes from that or from a misunderstanding on my part somewhere.

If there is a bug it can be here.

sbechet commented 3 months ago

Can you try xmrsplayer v0.4.8 please.

ofetch commented 3 months ago

@sbechet Thank you for trying to fix

I don't have perfect ears, maybe vibrato is correct, but I think after 3 seconds in, the oscillating notes sounds little bit different and are overwhelming the background notes a bit (they feel faster, but they're not) I have no idea how to explain in proper terminology.

If you think that chiptune sounds the same in xmrsplayer and other players, that means somethings is wrong with my ears/brain and I should close this issue.

sbechet commented 3 months ago

Hello ofetch,

I think I found, it's the orientation of the sinusoid that makes the difference. We have to do a -sin(pos) and not a sin(pos). Can you try again with last version?

sbechet commented 3 months ago

Hello ofetch, are you online? Can you try last version please? I'll be happy to close the bug.

ofetch commented 3 months ago

Hello @sbechet Sorry I've been AFK , thank you so much for the updates and fixes, I tried v0.5.4 and it sounds very close. I'm closing this issue now.