search

sbender9 / signalk-n2kais-to-nmea0183

Signal K provider to convert N2K AIS to NMEA 0183
2 stars 1 forks source link

Decouple plugin from provider #1

Open fabdrol opened 7 years ago

fabdrol commented 7 years ago

At the moment, this plugin depends on a custom event N2KAnalyzerOut (https://github.com/sbender9/signalk-n2kais-to-nmea0183/blob/master/index.js#L291), in provider n2kAnalyzer (https://github.com/SignalK/signalk-server-node/blob/master/providers/n2kAnalyzer.js#L41). This seems unnecessary and makes the plugin less future proof.

How would you feel about coupling this functionality to the servers' delta update stream?

sbender9 commented 7 years ago

It was just easier to do the mapping directly from the N2K messages. A version that uses deltas should probably go in https://github.com/SignalK/signalk-to-nmea0183