search

sbenhaim / protobrew

Meteor.js wiki engine
4 stars 4 forks source link

fix comment redactor typeahead and DRY #84

Closed funkyeah closed 10 years ago

funkyeah commented 11 years ago

typeahead in comments doesnt work and redactor is initialized twice

funkyeah commented 11 years ago

typeahead code catches only redactor in main entry instance redactor is initialized with code that is largely the same for entries and comments

sbenhaim commented 10 years ago

Redactor initialization has been pulled into the _EntryLib class. Typeahead is working for me both in entries and in comments, though I didn't do anything to my knowledge to fix it. It's just supposed to autocomplete for link urls, yes?

c12752eb15e33b50d09d05bf1ebc5e93d4b25812

funkyeah commented 10 years ago

yeah, i think the fact that merge the two calls probably fixed the css selectors the plugin uses

On Tue, Dec 17, 2013 at 10:02 PM, sbenhaim notifications@github.com wrote:

Redactor initialization has been pulled into the _EntryLib class. Typeahead is working for me both in entries and in comments, though I didn't do anything to my knowledge to fix it. It's just supposed to autocomplete for link urls, yes?

c12752ehttps://github.com/sbenhaim/protobrew/commit/c12752eb15e33b50d09d05bf1ebc5e93d4b25812

— Reply to this email directly or view it on GitHubhttps://github.com/sbenhaim/protobrew/issues/84#issuecomment-30814568 .