sbenthall / SHARKFin

Simulating Heterogeneous Agents with Finance
7 stars 5 forks source link

[WIP] create explode_agents method #201

Closed alanlujan91 closed 1 year ago

alanlujan91 commented 1 year ago

@sbenthall I believe this accomplishes what we wanted. However, I am not sure about the overhead of deepcopying the agents many times. Let me know what you think.

sbenthall commented 1 year ago

I wouldn't worry about the computational overhead at this point. We need something that works.

Can you confirm that doing this can be used to create a large population of Lucas agents? The LUCAS0 population could be 100 agents created in this way.

With an automated test to check?

alanlujan91 commented 1 year ago

@sbenthall only did 10 agents for test to reduce check time

sbenthall commented 1 year ago

Looks good. Is it done? I would put a line in the lucas0 test to make sure the pop has 10 agents in it, since that's the new feature

sbenthall commented 1 year ago

I'm assuming this is still [WIP]?

This fixes #195 ; I wonder if it's related to #202

alanlujan91 commented 1 year ago

Just need to do the last thing which is to check if there are indeed 10 agents after

alanlujan91 commented 1 year ago

@sbenthall should be done

sbenthall commented 1 year ago

Thanks @alanlujan91