Days per quarter is set not set and defalults to 90

sbenthall / SHARKFin

Simulating Heterogeneous Agents with Finance

6 stars 5 forks source link

Days per quarter is set not set and defalults to 90 #272

Closed mesalas closed 5 months ago

mesalas commented 5 months ago

In run_any_simulation.pywe calculate the price to dividend ratio as a field in the market_args dict. However we never pass the number of days so it defaults to 90 days. see code

This gives the wrong price to dividend ratio when not using 90 days.

we can fix this by passing the runs per quarter parameter, to make the parameter visible as an input.

sbenthall commented 5 months ago

We discussed this just now. 'runs' is actually a deprecated command line argument, but the spirit of the PR is right. I'll merge the PR and then correct the problems.