search

sberbank-ai-lab / RePlay

RecSys Library
https://sberbank-ai-lab.github.io/RePlay/
Apache License 2.0
68 stars 6 forks source link

pylint: self added as an argument in base classes #110

Closed monkey0head closed 2 years ago

monkey0head commented 2 years ago

New pylint does not like cases where a method in a base class is defined as a static method (does not have self as a first argument) and the same method in child class is not static (has self as a first argument)

I added self to base classes' methods signature in metrics and feature processor. This triggers pylint no-selt-use, so I disabled it.

monkey0head commented 2 years ago

@AleXXL1986 please have a look at this one first