search

sbergot / mothership-assistant

MIT License
13 stars 2 forks source link

make it so players can use skills on saves. #5

Closed pmfirestone closed 8 months ago

pmfirestone commented 8 months ago

rollSave now takes a skill as an additional argument. Its logic is now identical to rollStat. rollRest must pass a null skill argument, since rest rolls a save without an added skill. This fixes issue #3.

pmfirestone commented 8 months ago

Made a new request by making a specific feature branch for this bugfix. Ignore the previously-closed pull request.

sbergot commented 8 months ago

Thanks for the PR! Sorry I haven't replied to the previous one. I will look into it.

sbergot commented 8 months ago

I finally took the time to review and test & it looks good!