search

sberl / supersid

Cross-platform Sudden Ionospheric Disturbances (SID) monitor
MIT License
9 stars 9 forks source link

parameter `filename` of function `log_sid_format()` should be removed #73

Open fenrog opened 5 months ago

fenrog commented 5 months ago

rational: There are two callers of log_sid_format(): supersid.py and supersid_scanner.py. In both locations there is the note # filename is '' to ensure one file per station. Further the filename is set to an empty string.

The called function handles the filename as (filename or self.sid_file.get_sid_filename(station['call_sign'])). As filename is an empty string, this always evaluates to self.sid_file.get_sid_filename(station['call_sign'])

fenrog commented 5 months ago

fixed with https://github.com/sberl/supersid/pull/74