search

sberrevoets / SDCAlertView

The little alert that could
MIT License
1.86k stars 298 forks source link

Make framework extension-safe #238

Closed Johennes closed 6 years ago

Johennes commented 7 years ago

This makes the framework safe for use in app extensions. To achieve this, methods for finding the top view controller and presenting the alert on it were converted from Swift to Objective-C and marked with NS_EXTENSION_UNAVAILABLE_IOS.

sberrevoets commented 7 years ago

I think https://github.com/apple/swift/pull/12410 should take care of this on Swift's side - do you agree?

Johennes commented 6 years ago

I wish that had happened earlier. :/

We'll have to depend on our own fork of SDCAlertView until this makes it out then.

sberrevoets commented 6 years ago

Yeah I understand that's not ideal, but this change would be more or less permanent and with a cleaner solution on the horizon I'd rather wait for that.

Thanks for the effort though 🙏