Fix missing content view in action sheet

sberrevoets / SDCAlertView

The little alert that could

MIT License

1.86k stars 298 forks source link

Fix missing content view in action sheet #262

Closed ReDetection closed 6 years ago

ReDetection commented 6 years ago

Related to #261

ReDetection commented 6 years ago

Hm, I expected travis to fail the test, but it seems you UI tests are not included into travis

ReDetection commented 6 years ago

OK, seems bug was introduced in 88c0654e5684635f758d06e5dd7c51f431189a72, so it was an easy fix. However, view seems to have no padding now and I'm not sure if this good or bad. On one side, now it's fully controlled by user (no extra padding), but it's not backward compatible since the commit I mentioned

ReDetection commented 6 years ago

Ah, and it also somehow got invisible to the accessibility layer, so invisible to my test too 😞

sberrevoets commented 6 years ago

Thanks for submitting. I'll try to find some time soon to look at this.

sberrevoets commented 6 years ago

Looks great, thanks for submitting!