sberrevoets / SDCAlertView

The little alert that could
MIT License
1.86k stars 298 forks source link

Will be dismissed Closure #294

Closed lucho-dev closed 5 years ago

lucho-dev commented 5 years ago

Note: I used shouldDismissHandler as an entry point to update the UI of the controller that presented the alert. The idea was to update the UI right in the moment the AlertController started to animate its way out but shouldDismissHandler is not called when an outside tap is performed, only on actions and outsideTapHandler is called after the animation is done. I thought that it was faster and cleaner to just have a closure like outsideTapHandler called right before the alert is dismissed by any reason.

sberrevoets commented 5 years ago

One small naming comment but this looks good otherwise.

lucho-dev commented 5 years ago

feel free to review again, thanks!

sberrevoets commented 5 years ago

Thank you!