search

sbg / sevenbridges-cwl

Seven Bridges Python library for programatic generation of CWL workflows.
Other
19 stars 3 forks source link

`get_metadata()` function generates spurious "\r" on windows platforms #2

Closed ghost closed 5 years ago

ghost commented 6 years ago

On windows platforms the get_metadata() function seems to insert \r characters, this makes CWL created on windows unusable.

Thanks!

filiptubic commented 6 years ago

Hey @kaushik-work , can you place here some simple code example that demonstrates this issue? I assume you are creating a tool from bash code.

EDIT: My code completes successfully on Windows 10 (run tested using cwltool):

from sbg import cwl

t = cwl.from_bash(
    'echo "$(get_metadata in_file sample_id)"',
    docker='demo'
)
t.dump('tool.cwl')
filiptubic commented 5 years ago

Hey @kaushik-work should I close this issue?

ghost commented 5 years ago

@filiptubic yes please just close it - if I can replicate, I'll reopen. Thanks!