search

sbg / sevenbridges-python

SevenBridges Python Api bindings
Apache License 2.0
46 stars 27 forks source link

Discrepency in README.1st for credentials #72

Closed golharam closed 7 years ago

golharam commented 7 years ago

The readme.1st states "Use the configuration file $HOME/.sbgrc with defined parameters.", however below there is reference to "$HOME/.sevenbridges/credentials".

Which is correct?

golharam commented 7 years ago

In addition, in config.py, the Profile class refers to $HOME/.sevenbridges/credentials. So I think the reference to .sbgrc is incorrect.

class Profile(object):
    CREDENTIALS = os.path.join(os.path.expanduser('~'), '.sevenbridges',
                               'credentials')
    PROXIES = os.path.join(os.path.expanduser('~'), '.sevenbridges',
                           'sevenbridges-python', 'config')
jdagilliland commented 7 years ago

That's correct, I noticed the change the other day when I resurrected an old script. ~/.sbgrc no longer works with the library, but ~/.sevenbridges/credentials does.

delicb commented 7 years ago

@golharam @jdagilliland You are both right. This change was introduced with version 0.7.0, released on February 2nd.

@golharam You are right about documentation bug. We will make sure to iron it out. Sorry for the confusion.

SenadI commented 7 years ago

Resolved in 0.7.4