search

sbg / sevenbridges-r

Seven Bridges API Client, CWL Schema, Meta Schema, and SDK Helper in R
https://sbg.github.io/sevenbridges-r/
Apache License 2.0
35 stars 14 forks source link

Changed url of libssl in dockerfile #53

Closed mlrdk closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #53 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #53   +/-   ##
======================================
  Coverage    4.95%   4.95%           
======================================
  Files          25      25           
  Lines        5002    5002           
======================================
  Hits          248     248           
  Misses       4754    4754

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c894508...7d58a56. Read the comment docs.

nanxstats commented 7 years ago

Hi @mlrdk , thanks for the patch --- this is really nice! However, we have decided to rewrite this completely with a more general solution instead of installing specific versions of libssl. We expect to deliver the new Dockerfile soon.

mlrdk commented 7 years ago

@road2stat no problem. If it's no problem, I could take the task of writing the new dockerfile, since I agree that this one is really specific and a little bit outdated.

nanxstats commented 7 years ago

Hi Milorad @mlrdk , -- this should be fixed by https://github.com/sbg/sevenbridges-r/commit/50411f75171ebec6743f4b07d0ef3c300758ce06. Could you please take some time to test and see if the image works as expected? From my test it seems we could remove the libssl part safely.

mlrdk commented 7 years ago

@road2stat Sure thing, will get back to you here with updates!

mlrdk commented 7 years ago

Update

-The image works, and the shiny server is up and running!

nanxstats commented 7 years ago

@mlrdk -- great! Thank a lot for testing this out. We will probably roll out a new release to Bioconductor this weekend, with this fix and other improvements.