sbgisen / vesc

VESC Interface for ROS
Apache License 2.0
44 stars 33 forks source link

[vesc_driver] Fix bugs depending on an implementation-defined behavior #41

Closed ssr-yuki closed 2 years ago

ssr-yuki commented 2 years ago

Change Summary

The current codes include casting from double to uint32_t, and they have possibilities to cause implementation-defined behaviors. This PR fixes them.

Details

See Section 4.7 in ISO/IEC 14882:2011 for more detail. The draft version is published online: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf

Impacts

None.

Additional Information

The current codes DID work on