sbgisen / vesc

VESC Interface for ROS
Apache License 2.0
41 stars 33 forks source link

Feature/smooth diff #72

Closed nyxrobotics closed 1 year ago

nyxrobotics commented 1 year ago

Change Summary

Fixed a bug in the calculation of the differentiation of PID control. See the issue for details. This PR only fixes vesc_wheel_controller.cpp. I need another PR to fix vesc_servo_controller.cpp. Refactored PID controllers for both position control and velocity control.

Details

Impacts

References

Additional Information

jsupratman13 commented 1 year ago

@Tacha-S

If you have no problem with it, I will merge it.

Tacha-S commented 1 year ago

OK. It's resolved what I was wondering. If I find any probrem, I will open a new issue.