sbgisen / vesc

VESC Interface for ROS
Apache License 2.0
41 stars 33 forks source link

Support ROS2 humble #74

Closed Tacha-S closed 1 year ago

Tacha-S commented 1 year ago

Change Summary

Migrate hardware interface to ROS2 humble.

Details

Impacts

References

Additional Information

jsupratman13 commented 1 year ago

Thanks! Give me a little bit of time to learn how ROS2 works.

jsupratman13 commented 1 year ago

Timer events and std::thread also do not work properly, so control() is executed in cycle controller R/W.

Does this mean that timer event doesn't work properly when multiple vesc_hardware_interface are loaded in the ResourceManager?

Tacha-S commented 1 year ago

No, It means that hardware_interface can't create timer, because it's not node(don't have nodehandler).

jsupratman13 commented 1 year ago

Gotcha. We should consider moving the custom pid controls outside the hardware interface in the near future. For now, this looks good to me.