sbgn / libsbgn

Libraries for the Systems Biology Graphical Notation (SBGN); Java and C++
Other
15 stars 8 forks source link

Complex Glyphs depicting elements on the inside #17

Closed cannin closed 8 years ago

cannin commented 14 years ago

If we have another look at the complex in compartments.xml you will find the following glyphs encoded:

<glyph class="complex" id="glyph2"> <bbox x="360" y="150" w="140" h="160" /> </glyph> <glyph class="macromolecule" id="glyph3"> <label text="IGF" /> <bbox x="380" y="171" w="100" h="60" /> </glyph> <glyph class="macromolecule" id="glyph6"> <label text="IGFR" /> <bbox x="380" y="232" w="100" h="60" /> </glyph>

In other words we have glyphs with the same name multiple times in the file! This should not be the case, as this is not allowed by the SBGN specification (the second occurance should have a clone marker). For a human looking at the resulting picture it is clear what is meant: it was intended to depict the insides of the complex. I would argue that this is not how this should be encoded, rather something like the following should be used:

<glyph class="complex" id="glyph2"> <bbox x="360" y="150" w="140" h="160" /> <glyph class="macromolecule" id="glyph3"> <label text="IGF" /> <bbox x="380" y="171" w="100" h="60" /> </glyph> <glyph class="macromolecule" id="glyph6"> <label text="IGFR" /> <bbox x="380" y="232" w="100" h="60" /> </glyph>

</glyph>

Note the containment of the two glyphs inside the compartment glyph!

Reported by: fbergmann

cannin commented 14 years ago

Original comment by: amarillion

cannin commented 13 years ago

This has now been implemented, so I'm closing this.

Original comment by: amarillion

cannin commented 13 years ago

Original comment by: amarillion