mismatch betw. def. of bounding box in schema and test files

cannin commented 14 years ago

There is a mismatch between the definition of the bounding box for process nodes in the schema and the definition of the bounding boxes in the test files (see for example adh, clone-marker, compartments).

According to the schema the bounding box should include the ports and the lines to them. Comparing the png files and the sbgn files for the above mentioned test files this is not the case.

For example in adh.sbgn the process node is currently defined as <glyph class="process" orientation="horizontal" id="pn1"> <bbox x="148" y="168" w="24" h="24"/> <port x="148" y="180" id="pn1.1"/> <port x="172" y="180" id="pn1.2"/> </glyph>

Shouldn't it be defined as <glyph class="process" orientation="horizontal" id="pn1"> <bbox x="136" y="168" w="48" h="24"/> <port x="136" y="180" id="pn1.1"/> <port x="184" y="180" id="pn1.2"/> </glyph> ?

Reported by: tobicz

cannin commented 13 years ago

assigned_to: nobody --> tczauderna

Original comment by: amarillion

cannin commented 13 years ago

During the last libsbgn online meeting it was decided that the bounding box for process nodes/logical operators should be the inner square/circle. For the test files the ports should be defined according to the png images.

Original comment by: tobicz

cannin commented 13 years ago

status: open --> closed

Original comment by: tobicz

sbgn / libsbgn

mismatch betw. def. of bounding box in schema and test files #19