search

sbgn / libsbgn

Libraries for the Systems Biology Graphical Notation (SBGN); Java and C++
Other
15 stars 8 forks source link

Ant tests failing #38

Closed matthiaskoenig closed 5 years ago

matthiaskoenig commented 7 years ago

I tried to run the test target, but it fails.

ant test

Not sure if this ever worked. Probably it is necessary to include the library dependencies in the ant test target.

test:
    [javac] Compiling 3 source files to /home/mkoenig/git/libsbgn/org.sbgn/build
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
    [javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] /home/mkoenig/git/libsbgn/org.sbgn/test/org/sbgn/schematron/TestSchematronValidation.java:14: error: package org.apache.xpath does not exist
    [javac] import org.apache.xpath.SourceTree;
    [javac]                        ^
    [javac] /home/mkoenig/git/libsbgn/org.sbgn/test/org/sbgn/ExtensionDemo.java:50: error: cannot find symbol
    [javac]         sbgn.setMap(map);
    [javac]             ^
    [javac]   symbol:   method setMap(Map)
    [javac]   location: variable sbgn of type Sbgn
    [javac] /home/mkoenig/git/libsbgn/org.sbgn/test/org/sbgn/ExtensionDemo.java:94: error: cannot find symbol
    [javac]         Glyph g = sbgn.getMap().getGlyph().get(0);
    [javac]                                ^
    [javac]   symbol:   method getGlyph()
    [javac]   location: interface List<Map>
    [javac] /home/mkoenig/git/libsbgn/org.sbgn/test/org/sbgn/bindings/Test.java:23: error: incompatible types: List<Map> cannot be converted to Map
    [javac]         Map map = sbgn.getMap();
    [javac]                              ^
    [javac] 4 errors
    [javac] 3 warnings

It would be interesting if anybody ever got the tests running via the ant target.

This is part of #35 , continous integration.

cannin commented 7 years ago

Doesn't solve the problem, but a step in the right direction. I added the missing dependency:

403d6d131104f5478c81be2fa0cdb75a16b101f4

Not sure about the "cannot find symbol" issue; the appropriate class is imported.

fbergmann commented 5 years ago

thanks for letting us know ... indeed the latest version supports multiple maps, thus getMap returns now a list of things ... also there will be no more setMap() ... but rather getMap().add

I'll take this one.

fbergmann commented 5 years ago

ok, fixed the build failures ... and sort of made the schematron validation work with the new version attribute as fallback. with that all tests pass