search

sbgn / libsbgn

Libraries for the Systems Biology Graphical Notation (SBGN); Java and C++
Other
15 stars 8 forks source link

Encoding issue #59

Closed piotr-gawron closed 4 years ago

piotr-gawron commented 4 years ago

This pull request solves the problem of reading sbgn 0.2/0.1 on operating systems that have defined files encoding different than encoding of xml file. This can happen for instance on windows machine with default ISO-8859-1 encoding and typical xml file encoded using UTF-8.

There is also a test unit that shows what happens in such situation.

fbergmann commented 4 years ago

Thank you!

piotr-gawron commented 4 years ago

dear @fbergmann,

Would it be possible to create a release that includes this patch? It's a bit hard to workaround the issue solved here unless I include modified libsbgn source in my code.

fbergmann commented 4 years ago

will do so tomorrow .. cheers

fbergmann commented 4 years ago

milestone3.3 is now available on jitpack.