search

sbgn / process-descriptions

SBGN PD specification
2 stars 4 forks source link

section for multimers is written as if multimer was a glyph #227

Closed adrienrougny closed 3 months ago

adrienrougny commented 6 years ago

Target

Specification

Issue type

Bug

Bug report

Level and version Level: 1 Version: 2

Section and page Section: 2.4.5 (Glyph: Multimer) Page: 15

Bug description

The Multimer section is written as if multimer was one glyph. There are in fact multiple multimer glyphs. It should be better presented.

Proposed solution Use the plural "multimers" in the section name and elsewhere, and maybe more rewriting. Maybe add the following table with two columns (instead of figure 2.13?):

Glyph name Glyph
multimer of macromolecules drawing of the glyph
multimer of simple chemicals drawing of the glyph
... ...
adrienrougny commented 11 months ago

Only partially taken into account (table).

hasanbalci commented 3 months ago

I changed the section name to "Glyph: Multimers" and made a few small additions to the text to emphasize different types of multimers.

hasanbalci commented 3 months ago

We decided to change the title as Glyphs: Multimers.