search

sbhadraweb / thegamesdb

Automatically exported from code.google.com/p/thegamesdb
0 stars 0 forks source link

Banner layout doesn't match between platform and game pages. #240

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If you look at banners on a gamepage, banners are raised off of the page bottom 
and have the dots below the banners indicating it's 1 of 3. For example.

http://thegamesdb.net/game/140/#gameContentBottom

When you look at a platform page with multiple banners, the banner is pressed 
against the page bottom and doesn't provide space for the count indicator. For 
example.

http://thegamesdb.net/platform/nintendo-entertainment-system-nes/#gameContentTop

Original issue reported on code.google.com by redshirt...@gmail.com on 14 Jan 2012 at 7:22

GoogleCodeExporter commented 9 years ago 
I noticed this issue as well.  Thanks for catching this!

Original comment by smid...@gmail.com on 15 Jan 2012 at 4:25

GoogleCodeExporter commented 9 years ago 
This is actually the result of a larger site-wide issue... the footer is 
actually being overlayed over the bottom of pages and not allowing the 
margin/padding on the bottom of the page to be shown.

This was the result of a quick fix we made on Peach launch day, will look into 
tidying it up and restoring correct display of the bottom of pages.

Original comment by a...@penoval.co.uk on 17 Jan 2012 at 7:59

GoogleCodeExporter commented 9 years ago 
after r338 this seems to still be an issue.  Can someone please verify?

Original comment by smid...@gmail.com on 3 Mar 2012 at 9:37

GoogleCodeExporter commented 9 years ago 
Issue seems to be per-browser now. The footer overlays the banner selector
in firefox. However works properly in IE and Opera. Have not tested Chrome.

Original comment by redshirt...@gmail.com on 3 Mar 2012 at 10:11

GoogleCodeExporter commented 9 years ago 
I am still seeing the problem in Chrome.

Original comment by smid...@gmail.com on 4 Mar 2012 at 1:36

GoogleCodeExporter commented 9 years ago 
Would you guys try an "F5" on any affected pages you come across, I get a 
feeling that this is due to a css file that has been cached and not re-fetched 
automatically by the browsers. I have not been able to re-produce this issue in 
any of my browsers. If it is a cached css file as I believe, the browser will 
automagically re-fetch the affected file on it's own sometime soon.

Original comment by a...@penoval.co.uk on 4 Mar 2012 at 11:15

GoogleCodeExporter commented 9 years ago 
Just retested with firefox. Banner selectors were visible above footer. Does 
indeed appear to be a cached css file issue.

Original comment by redshirt...@gmail.com on 4 Mar 2012 at 11:20

GoogleCodeExporter commented 9 years ago 
r338 completes this issue.

Original comment by smid...@gmail.com on 4 Mar 2012 at 7:48