sbi-benchmark / sbibm

Simulation-based inference benchmark
https://sbi-benchmark.github.io
MIT License
88 stars 34 forks source link

No default validation of prior args #31

Closed jan-matthis closed 2 years ago

jan-matthis commented 2 years ago

In recent versions of PyTorch, default behavior for distributions changed to validate args by default. As consequence of this, evaluating an distribution out of its support throws an error rather than returning torch(-inf). This PR restores the old behavior by disabling validation for the prior distributions. In the future, we might change the rejection sampling algorithms instead, by using within_support from sbi.