sbi-benchmark / sbibm

Simulation-based inference benchmark
https://sbi-benchmark.github.io
MIT License
88 stars 34 forks source link

Follow-up to #27 #37

Closed jan-matthis closed 2 years ago

jan-matthis commented 2 years ago

Turns out the solution proposed in #27 to adapt the usage of log_abs_det_jacobian for torch>=1.8 was not ideal -- in particular, we only need to use the IndependentTransform when we do not request automatic transforms. The way we set up priors for the tasks, event dimensions are already declared. Wrapping twice will lead to unexpected behavior. This PR fixes this problem and adds new tests to detect related issues in the future.