search

sbi-benchmark / sbibm

Simulation-based inference benchmark
https://sbi-benchmark.github.io
MIT License
88 stars 34 forks source link

Fix latest sample init strategy for snle and snre. #57

Closed janfb closed 1 year ago

janfb commented 1 year ago

closes #56

after round 2, we are using the latest posterior samples from the previous round as inits for the current round. The posterior._mcmc_init_params are set to the latest samples at the end of the sample method. With the new sampler interface, however, we are creating a new posterior object at every iteration so that the latest samples are not set. In this fix, we copy the posterior._mcmc_init_params from the proposal (posterior from previous round) to the newly created posterior of the current round.

Independent from #56 , I here also adapt to the new z-scoring api (separate commit).

gisilvs commented 1 year ago

I have tested the changes and everything seems to work smoothly now, thanks!