sbi-dev / sbi

Simulation-based inference toolkit
https://sbi-dev.github.io/sbi/
Apache License 2.0
546 stars 133 forks source link

MTN better split the linting process from the CI/CD workflow #1164

Closed tomMoral closed 4 weeks ago

tomMoral commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.94%. Comparing base (1b268b8) to head (46dd175). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1164 +/- ## =========================================== - Coverage 83.08% 72.94% -10.14% =========================================== Files 92 93 +1 Lines 7259 7371 +112 =========================================== - Hits 6031 5377 -654 - Misses 1228 1994 +766 ``` | [Flag](https://app.codecov.io/gh/sbi-dev/sbi/pull/1164/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sbi-dev) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/sbi-dev/sbi/pull/1164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sbi-dev) | `72.94% <ø> (-10.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sbi-dev#carryforward-flags-in-the-pull-request-comment) to find out more. [see 23 files with indirect coverage changes](https://app.codecov.io/gh/sbi-dev/sbi/pull/1164/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sbi-dev)
tomMoral commented 4 weeks ago

This is part of the changes that were proposed in #1008 . For the failure, I think it is something that is already on the main branch no?