sbi-dev / sbi

Simulation-based inference toolkit
https://sbi-dev.github.io/sbi/
Apache License 2.0
581 stars 151 forks source link

Add a common MDN network interface (consistent with new DensityEstimators) #989

Open manuelgloeckler opened 7 months ago

manuelgloeckler commented 7 months ago

Description

The MDN i.e. Gaussian Mixture Density network, is a density estimator which gets a lot of "special" treatment.

Hence it may be good to collapse all current MDN wrappers/functionalities into a single class MDNDensityEstimator, which does follow the new DensityEstimator.

Advantages:

bkmi commented 7 months ago

I find the SNPE_A_MDN class quite confusing. Is there a loss implemented for it yet? Why does it only inherit from DensityEstimator but not implement all methods?

janfb commented 2 months ago

This is being worked on in #1042 but it will not make it into the release in August.