Refactor neural_nets model structure

sbi-dev / sbi

Simulation-based inference toolkit

https://sbi-dev.github.io/sbi/

Apache License 2.0

578 stars 145 forks source link

Refactor neural_nets model structure #991

Closed gmoss13 closed 1 month ago

gmoss13 commented 6 months ago

After the new DensityEstimator interface is introduced, we have a confusing structure:

[x] neural_nets.density_estimators should contain only one file for flows, containing all classes of flow-based density estimators
[x] neural_nets.flow.py and neural_nets.mdn.py should be combined and the file should be explicitly named as a util file (containing only builder functions for flow-based density estimators. Potentially move this to utils.

fariedabuzaid commented 6 months ago

I can have a look into that.

janfb commented 1 month ago

factory.py contains the meta build functions like posterior_nn etc, while we have individual files for the build_xyz(...) build functions, e.g., flow.py, mdn.py etc. This should be refactored into a more logically file structure.

janfb commented 1 month ago

closed with #1238 and #1237