From my point of view, #18 is not fixed by 0a2d6d8 given os.makedirs(LOGFILE_DIR,0o0750) only works if MacroMilter is started as root but not when MacroMilter is started as non-privileged user, e.g. postfix, because that user is by default unable to create a directory in /var/log/ anyway. Thus this patch suggests to change the process' umask in general to avoid world readable files.
From my point of view, #18 is not fixed by 0a2d6d8 given
os.makedirs(LOGFILE_DIR,0o0750)
only works if MacroMilter is started asroot
but not when MacroMilter is started as non-privileged user, e.g.postfix
, because that user is by default unable to create a directory in/var/log/
anyway. Thus this patch suggests to change the process' umask in general to avoid world readable files.