search

sbidy / MacroMilter

This python based milter (mail-filter) checks an incoming mail for suspicious VBA macro code in MS 20xx Office attachments (doc, xls, ppt ...).
MIT License
37 stars 14 forks source link

Missing configuration default when upgrading from 3.4.3 to 3.5.x #39

Closed robert-scheck closed 6 years ago

robert-scheck commented 6 years ago

When upgrading from MacroMilter 3.4.3 to 3.5.x without changing the config.ini, the daemon fails as follows due to a missing configuration default if unset:

May 11 00:32:34 tux macromilter: Traceback (most recent call last):
May 11 00:32:34 tux  macromilter: File "/usr/bin/macromilter", line 105, in <module>
May 11 00:32:34 tux  macromilter: UMASK = int(config.get('Milter', 'UMASK'), base=0)
May 11 00:32:34 tux  macromilter: File "/usr/lib64/python2.7/ConfigParser.py", line 618, in get
May 11 00:32:34 tux  macromilter: raise NoOptionError(option, section)
May 11 00:32:34 tux  macromilter: ConfigParser.NoOptionError: No option 'umask' in section: 'Milter'
sbidy commented 6 years ago

Merged and reviewed.

robert-scheck commented 6 years ago

@sbidy, do you see a chance to create a tag/release including this fix? This would help to get a current version of MacroMilter into Fedora and EPEL.