codecov-commenter
commented
2 years ago Codecov Report
Merging #126 (c06e767) into master (ed71ae3) will increase coverage by
0.09%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 87.34% 87.43% +0.09%
==========================================
Files 12 12
Lines 782 788 +6
==========================================
+ Hits 683 689 +6
Misses 99 99 | Impacted Files | Coverage Δ | |
|---|---|---|
| pywizlight/bulb.py | 89.84% <100.00%> (+0.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ed71ae3...c06e767. Read the comment docs.
bdraco
sbidy
We needed to wait a little bit longer for the OSError's to come back so we now backoff progressively up to 3s between sends and increases the timeout to 13s since it can take a few more seconds for error to arrive. This means we now get a much better error when the bulb is offline, and we aren't making a situation where the problem is wifi congestion even worse.
Also since we are using a future, it doesn't matter which udp message the bulb gets and respond to, since as soon as it does, the send task will be canceled and we will declare success.